Add coverity checks to CI #105
Labels
CI
Continous Integration
Comments
|
Some tests are in place in Alien . Some code can be shared for Arcane. |
stdcm
pushed a commit
to stdcm/framework
that referenced
this issue
Jun 26, 2023
* Init plugin Ginkgo * Init test Ginkgo * Prepare structure for Ginkgo plugin * add linear algebra and solver files * Add Empty Converter files SimpleCSR -> Ginkgo Matrix SimpleCSR -> Ginkgo Vector * Ginkgo plugin : Class Alien::Ginkgo::Matrix * Ginkgo plugin : Class Alien::Ginkgo::Vector * Linear Algebra : mult. * Branch ginkgo CG solver + Jacobi. Using raw pointers to gko::matrix::Csr. /!\ Ginkgo needs owning pointers. Therefore, cast to shared_pointers. But -> double free bug Thus, using a shared_pointer with a deleter doing nothing. To be improved/discussed. * Fixed bug in Vector structure. matmult resulting gko vector was false. * Format * Add norm2, axpy and copy. * Add logger, get nb iterations and residual. * Format * Add ginkgo residual logger (reuse Ginkgo's example) * Add machine_backend cpp and h files, to select the backend to be used (ref, omp, gpu). * Add missing include file. (After rebase conflict resolution) * Format * Fix coverity checks * suppress unused variables * Update CMakeLists.txt * Init plugin Ginkgo * Init test Ginkgo * Prepare structure for Ginkgo plugin * add linear algebra and solver files * Add Empty Converter files SimpleCSR -> Ginkgo Matrix SimpleCSR -> Ginkgo Vector * Ginkgo plugin : Class Alien::Ginkgo::Matrix * Ginkgo plugin : Class Alien::Ginkgo::Vector * Linear Algebra : mult. * Branch ginkgo CG solver + Jacobi. Using raw pointers to gko::matrix::Csr. /!\ Ginkgo needs owning pointers. Therefore, cast to shared_pointers. But -> double free bug Thus, using a shared_pointer with a deleter doing nothing. To be improved/discussed. * Fixed bug in Vector structure. matmult resulting gko vector was false. * Format * Add norm2, axpy and copy. * Add logger, get nb iterations and residual. * Format * Add ginkgo residual logger (reuse Ginkgo's example) * Add machine_backend cpp and h files, to select the backend to be used (ref, omp, gpu). * Add missing include file. (After rebase conflict resolution) * Format * Fix coverity checks * suppress unused variables * Init Ginkgo bench * read vector from mtx file * Add GMRES, BICG, BICGSTAB solvers. Design needs to be improved. Using Jacobi preconditionner by default. Also needs to be improved. * Add solver versions with no preconditioner. * Add solver timing * Add command line parameters for ginkgo bench : solver, preconditioner, matrix and vector. * Clean Ginkgo bench. * Add GinkgoConfig.h.in to set Ginkgo's executor. * Code factorization using Ginkgo's set_preconditioner method. * Code Refactoring : - Add ginkgo_linear_solver.h - Clean comments and output * Add Ginkgo to simpleCSR converter * Init plugin Ginkgo * Init test Ginkgo * Prepare structure for Ginkgo plugin * add linear algebra and solver files * Add Empty Converter files SimpleCSR -> Ginkgo Matrix SimpleCSR -> Ginkgo Vector * Ginkgo plugin : Class Alien::Ginkgo::Matrix * Ginkgo plugin : Class Alien::Ginkgo::Vector * Linear Algebra : mult. * Branch ginkgo CG solver + Jacobi. Using raw pointers to gko::matrix::Csr. /!\ Ginkgo needs owning pointers. Therefore, cast to shared_pointers. But -> double free bug Thus, using a shared_pointer with a deleter doing nothing. To be improved/discussed. * Fixed bug in Vector structure. matmult resulting gko vector was false. * Format * Add norm2, axpy and copy. * Add logger, get nb iterations and residual. * Format * Add ginkgo residual logger (reuse Ginkgo's example) * Add machine_backend cpp and h files, to select the backend to be used (ref, omp, gpu). * Add missing include file. (After rebase conflict resolution) * Format * Fix coverity checks * suppress unused variables * Update CMakeLists.txt * Init plugin Ginkgo * Init test Ginkgo * Prepare structure for Ginkgo plugin * add linear algebra and solver files * Add Empty Converter files SimpleCSR -> Ginkgo Matrix SimpleCSR -> Ginkgo Vector * Ginkgo plugin : Class Alien::Ginkgo::Matrix * Ginkgo plugin : Class Alien::Ginkgo::Vector * Linear Algebra : mult. * Branch ginkgo CG solver + Jacobi. Using raw pointers to gko::matrix::Csr. /!\ Ginkgo needs owning pointers. Therefore, cast to shared_pointers. But -> double free bug Thus, using a shared_pointer with a deleter doing nothing. To be improved/discussed. * Fixed bug in Vector structure. matmult resulting gko vector was false. * Format * Add norm2, axpy and copy. * Add logger, get nb iterations and residual. * Format * Add ginkgo residual logger (reuse Ginkgo's example) * Add machine_backend cpp and h files, to select the backend to be used (ref, omp, gpu). * Add missing include file. (After rebase conflict resolution) * Format * Fix coverity checks * suppress unused variables * Init Ginkgo bench * read vector from mtx file * Add GMRES, BICG, BICGSTAB solvers. Design needs to be improved. Using Jacobi preconditionner by default. Also needs to be improved. * Add solver versions with no preconditioner. * Add solver timing * Add command line parameters for ginkgo bench : solver, preconditioner, matrix and vector. * Clean Ginkgo bench. * Add GinkgoConfig.h.in to set Ginkgo's executor. * Code factorization using Ginkgo's set_preconditioner method. * Code Refactoring : - Add ginkgo_linear_solver.h - Clean comments and output * Add Ginkgo to simpleCSR converter * Fix CMakeLists.txt because of bad conflict resolution during rebase on origin/main. * Update solver output. Modify stop criterion to RelativeResidualNorm. * Fix solver timing. * Add convergence and result information at the end of the bench. * Change Convergence criteria for AbsoluteResidualNorm. And some cosmetic changes. * Init plugin Ginkgo * Init test Ginkgo * Ginkgo plugin : Class Alien::Ginkgo::Matrix * Add ginkgo residual logger (reuse Ginkgo's example) * Init plugin Ginkgo * Init test Ginkgo * Prepare structure for Ginkgo plugin * add linear algebra and solver files * Add Empty Converter files SimpleCSR -> Ginkgo Matrix SimpleCSR -> Ginkgo Vector * Ginkgo plugin : Class Alien::Ginkgo::Matrix * Ginkgo plugin : Class Alien::Ginkgo::Vector * Linear Algebra : mult. * Branch ginkgo CG solver + Jacobi. Using raw pointers to gko::matrix::Csr. /!\ Ginkgo needs owning pointers. Therefore, cast to shared_pointers. But -> double free bug Thus, using a shared_pointer with a deleter doing nothing. To be improved/discussed. * Fixed bug in Vector structure. matmult resulting gko vector was false. * Format * Add norm2, axpy and copy. * Add logger, get nb iterations and residual. * Format * Add ginkgo residual logger (reuse Ginkgo's example) * Format * Add GinkgoConfig.h.in to set Ginkgo's executor. * Code Refactoring : - Add ginkgo_linear_solver.h - Clean comments and output * Use MatrixMarket vector reader * Add ginkgo plugin omp and ref configurations to CMakePresets * Add FindGinkgo.cmake file. /!\ Dummy path ! * Use GingkoConfig.cmake We do not need a FindGinkgo as Ginkgo provides a GinkgoConfig.cmake. Fix include path for Ginkgo. * Add CMakeUserPresets.json to .gitignore * Adding Gingko tests with github actions * Fix typo to run Gingko tests. * - suppress ginkgo_logger.h - _buildblock throws - update CHANGE - update cmake_minimum_required * Complete Linear Algebra * Suppress ginkgo-omp and ginkgo-ref from CMakePresets.json * Add support for distributed objects in simplecsr to gko matrix converter. * Replace public struct ginkgo_executor by Class with private attribute and friend classes. * Use temporary vector reader. * format * More robust detection of ginkgo backends. CMake should fail if no backend is selected or if the selected backend is not available. Co-authored-by: Nathalie Möller <[email protected]> Co-authored-by: Cédric Chevalier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: