Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic -- it's only a user error #86

Open
webbnh opened this issue Apr 19, 2024 · 1 comment
Open

Do not panic -- it's only a user error #86

webbnh opened this issue Apr 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@webbnh
Copy link
Contributor

webbnh commented Apr 19, 2024

Describe the bug

Per #85 (comment), we should not be issuing a panic as a result of a user error. The error should be detected at an earlier point when it is reasonable to return an error to the user. A panic, aside from being ugly, is likely to be misconstrued by a user as a problem internal to Arca. We should instead be reporting an error as we would in other cases of a malformed workflow file.

@webbnh webbnh added the bug Something isn't working label Apr 19, 2024
@jaredoconnell
Copy link
Contributor

For this task, we will need to add a recursive validation function to report errors before they're used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants