Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need improve error handling #60

Open
YarikTH opened this issue Nov 21, 2020 · 0 comments
Open

Need improve error handling #60

YarikTH opened this issue Nov 21, 2020 · 0 comments

Comments

@YarikTH
Copy link

YarikTH commented Nov 21, 2020

I mistakenly passed my artefacts folder path to the "--analize" arg and ClangBuildAnalyzer crashed with std::bad_alloc from BufferedReader(FILE* f) when "fsize" was calculated as 9223372036854775807.
I think it's better to add some additional checks for stupid errors like this. At least need to check that path is valid and it points to a file.
Also, errors handling when working with fseek, ftello64 etc is completely skipped and ftello64 even returns signed int64_t and it also wasn't checked before being implicitly cast to size_t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant