-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper RC's #262
Comments
See #264 for thoughts and recommendations. @arangamani needs to review. |
This is in progress now. So will close this in a few weeks if the wheels turn more. |
@luke-hill sitting down to review the additional tickets listed in #264 - my preference is that you leave this open until we get the release out; just wanted to give you an update. |
Cool thanks for that. Yeh I'll close it once a release candidate of "some" value is cut. |
Any updates on this? We're still merging in code and haven't cut anything. |
All the things we've been testing and merging are going into v2.0, as detailed here: https://github.com/arangamani/jenkins_api_client/pull/264/files We're still working on it. |
Oki, is there a reason you're merging like 20+ PR's into one release candidate? Especially if it's a breaking change? |
Given that it's a breaking change, it justifies a major version release. @arangamani and I chatted it out back when you requested this and decided it made sense to pull in all these languishing PRs and make a v2.0. Edit: Github doesn't seem to want to link to the comment thread on the PR on the Changelog, but anyway, we decided to loop them all in and make a v2.0 after listing out all the changes. |
Hey @katelovescode , why was #264 closed? Is there anything one could do to bring this forward? |
Can I make a suggestion that given there has been a bunch of activity on this repo over the last 3 months or so we create and hit some proper RC's.
Given there has been a good 40 commits into master, we need to maybe think about when the next version of this is released how many things could go wrong?
cc/ @katelovescode As you seem to have the auth creds
The text was updated successfully, but these errors were encountered: