Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(misconf): Remove unused options #7896

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Nov 9, 2024

Description

These options aren't often used due to reasons described in the disucussion and can be deprecated.

Related issues

Related discussion

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this Nov 9, 2024
@simar7 simar7 marked this pull request as ready for review November 19, 2024 04:55
@nikpivkin
Copy link
Contributor

@simar7 Does that mean we should now only support deny rules? https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L388-L395

@nikpivkin
Copy link
Contributor

combined is also mentioned in the documentation.

@simar7
Copy link
Member Author

simar7 commented Nov 20, 2024

@simar7 Does that mean we should now only support deny rules? https://github.com/aquasecurity/trivy/blob/main/pkg/iac/rego/scanner.go#L388-L395

Yes, there's even a comment about this https://github.com/aquasecurity/trivy/blame/797b36fbad90b8e7f04e16e2cf08d6bdc0255ac7/pkg/iac/rego/scanner.go#L387

Actually I just realized we didn't issue an announcement for this change. I will prepare that first.

Discussion here: #7961

@nikpivkin
Copy link
Contributor

@simar7 As we discussed earlier, will support for warn and violation rules be removed?

@simar7
Copy link
Member Author

simar7 commented Nov 29, 2024

@simar7 As we discussed earlier, will support for warn and violation rules be removed?

Yes, is there something that I've missed in this PR?

@simar7 simar7 added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@simar7 simar7 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into aquasecurity:main with commit 511b7d3 Nov 29, 2024
12 checks passed
@simar7 simar7 deleted the refactor-7849 branch November 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(misconf): Remove unused options
2 participants