Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): Fixed scope for China Cloud #7560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bloomadcariad
Copy link

@bloomadcariad bloomadcariad commented Sep 19, 2024

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bloomadcariad bloomadcariad changed the title Fixed scope for China Cloud fix(misconf) Fixed scope for China Cloud Sep 19, 2024
@bloomadcariad bloomadcariad changed the title fix(misconf) Fixed scope for China Cloud fix(misconf): Fixed scope for China Cloud Sep 19, 2024
@bloomadcariad
Copy link
Author

It doesn't seem like the test failures would have anything to do with my fix. Can we force a re-run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure China scope is incorrect
3 participants