Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): unify the ACL bucket values #7238

Closed
nikpivkin opened this issue Jul 26, 2024 · 1 comment
Closed

fix(misconf): unify the ACL bucket values #7238

nikpivkin opened this issue Jul 26, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning

Comments

@nikpivkin
Copy link
Contributor

In Terraform, bucket ACL values are set in kebab-case format, while in CloudFormation they are set in CamelCase

Example for Terraform: private, public-read, public-read-write, aws-exec-read, authenticated-read, and log-delivery-write
Example for CloudFormation: AuthenticatedRead | AwsExecRead | BucketOwnerFullControl | BucketOwnerRead | LogDeliveryWrite | Private | PublicRead | PublicReadWrite

Required:

  • Fix the default value for CloudFormation.
  • Fix the check as it only checks for ACLs in kebab-case format. Or just cast the ACL from CamelCase to kebab-case.
@nikpivkin nikpivkin added kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning labels Jul 26, 2024
@nikpivkin
Copy link
Contributor Author

Turns out it's already supported.

@nikpivkin nikpivkin closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
None yet
Development

No branches or pull requests

1 participant