Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secret): add support of GitHub fine-grained tokens #5650

Closed
DmitriyLewen opened this issue Nov 24, 2023 Discussed in #5649 · 2 comments · Fixed by #5740
Closed

feat(secret): add support of GitHub fine-grained tokens #5650

DmitriyLewen opened this issue Nov 24, 2023 Discussed in #5649 · 2 comments · Fixed by #5740
Assignees
@DmitriyLewen
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. scan/secret Issues relating to secret scanning

Comments

@DmitriyLewen
Copy link
Contributor

Discussed in #5649

We only support classic GitHub token format.

But GitHub also uses a new format: ^github_pat...
@DmitriyLewen DmitriyLewen added kind/feature Categorizes issue or PR as related to a new feature. scan/secret Issues relating to secret scanning labels Nov 24, 2023
@DmitriyLewen DmitriyLewen self-assigned this Nov 24, 2023
@knqyf263 knqyf263 changed the title feat(secret): add support of Github fine-grained tokens feat(secret): add support of GitHub fine-grained tokens Nov 26, 2023
@knqyf263 knqyf263 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 26, 2023
@knqyf263
Copy link
Collaborator

It is defined here.
https://github.com/aquasecurity/trivy/blob/ad977a4256920d6269e84c82e4f42bbe244a2c5a/pkg/fanal/secret/builtin-rules.go

sourav977 added a commit to sourav977/trivy that referenced this issue Dec 6, 2023
@sourav977
add support of GitHub fine-grained tokens
273271b 
Issue: aquasecurity#5650
@sourav977 sourav977 mentioned this issue Dec 6, 2023
Merged
6 tasks
@sourav977
Copy link
Contributor

created PR: #5740 , please review.

sourav977 added a commit to sourav977/trivy that referenced this issue Dec 7, 2023
@sourav977
renamed ID, added test case
d2b833c 
Issue: aquasecurity#5650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriyLewen DmitriyLewen

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. scan/secret Issues relating to secret scanning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(secret): add support of GitHub fine-grained tokens sourav977/trivy
3 participants
@knqyf263 @sourav977 @DmitriyLewen