Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dedupe avd-id and id for policies #4993

Closed
simar7 opened this issue May 11, 2023 · 2 comments
Closed

feat: Dedupe avd-id and id for policies #4993

simar7 opened this issue May 11, 2023 · 2 comments
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. scan/misconfiguration Issues relating to misconfiguration scanning

Comments

@simar7
Copy link
Member

simar7 commented May 11, 2023

Today both avd-id and id exist for our rego policies. Need to investigate why there's a need for both and if not, remove one in the favour of the other.

An example https://github.com/aquasecurity/defsec/blob/master/rules/docker/policies/add_instead_of_copy.rego#L10-L11

This needs to be carefully done as there might be users of either/or of these IDs.

@simar7 simar7 changed the title feat: Dedupe avd-id and id for policies feat: Dedupe avd-id and id for policies May 11, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@simar7 simar7 transferred this issue from aquasecurity/defsec Aug 15, 2023
@simar7 simar7 added priority/backlog Higher priority than priority/awaiting-more-evidence. scan/misconfiguration Issues relating to misconfiguration scanning labels Aug 15, 2023
@simar7
Copy link
Member Author

simar7 commented Mar 5, 2024

As found out in #5195 trivy uses the ID field to generate a URL to AVD. So for the time being we will need both.

@simar7 simar7 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
None yet
Development

No branches or pull requests

1 participant