Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Prometheus ServiceMonitor apiVersion via variable #2234

Closed
tjmullicani opened this issue Aug 22, 2024 · 1 comment
Closed

Set Prometheus ServiceMonitor apiVersion via variable #2234

tjmullicani opened this issue Aug 22, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.

Comments

@tjmullicani
Copy link

The Helm chart hard-codes the ServiceMonitor apiVersion to monitoring.coreos.com/v1. This should be configurable using a variable, as Microsoft Azure Prometheus uses azmonitoring.coreos.com/v1 instead (https://learn.microsoft.com/en-us/azure/azure-monitor/containers/prometheus-metrics-scrape-crd#example-pod-monitor).
@tjmullicani tjmullicani added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 22, 2024
@tjmullicani tjmullicani changed the title Allow user to set Prometheus ServiceMonitor apiVersion Set Prometheus ServiceMonitor apiVersion via variable Aug 22, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Oct 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjmullicani