Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason for ignoring artifactVersion in GAV validation for jar files ? #260

Open
john-d8r opened this issue Oct 3, 2023 · 0 comments

Comments

@john-d8r
Copy link

john-d8r commented Oct 3, 2023

When parsing jar files, go-dep-parser validates GAV info against maven repo when pom.properties is not found

And in the validation, artifactVersion is currently being ignored.

if manifestProps.Valid() {
// Even if MANIFEST.MF is found, the groupId and artifactId might not be valid.
// We have to make sure that the artifact exists actually.
if ok, _ := p.client.Exists(manifestProps.GroupID, manifestProps.ArtifactID); ok {
// If groupId and artifactId are valid, they will be returned.
return append(libs, manifestProps.Library()), nil, nil
}
}

Is this intentional ? (any reason for not including version here)

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant