-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin SDK] add docs for sponsored txns... #701
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
You can collapse the fee payer signing and submitting steps into one by using the `signAndSubmitAsFeePayer` method. | ||
|
||
```kotlin | ||
val committedTxn = aptos.signAndSubmitAsFeePayer(signer, aliceAuthenticator, txn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the previous examples, the variable signer
should be renamed to sponsor
, as that's how the fee payer account is referenced throughout the documentation.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update this to say sponsor. This bot seems pretty decent :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise, let me know when you fix the signer -> sponsor
You can collapse the fee payer signing and submitting steps into one by using the `signAndSubmitAsFeePayer` method. | ||
|
||
```kotlin | ||
val committedTxn = aptos.signAndSubmitAsFeePayer(signer, aliceAuthenticator, txn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update this to say sponsor. This bot seems pretty decent :)
- for consistency, renamed signer to sponsor
guess we clear now, @gregnazario |
Description
This PR introduces detailed documentation for implementing sponsored transactions in the Kotlin SDK.
Checklist
pnpm spellcheck
?pnpm fmt
?pnpm lint
?