Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-compiler-v2] constants should not be able to refer to other constants #14648

Closed
brmataptos opened this issue Sep 16, 2024 · 1 comment · Fixed by #14741
Closed
Assignees
Labels

Comments

@brmataptos
Copy link
Contributor

brmataptos commented Sep 16, 2024

🐛 Bug

See the test outputs:

  • third_party/move/move-compiler/tests/move_check/typing/constant_allowed_but_not_supported.exp
  • third_party/move/move-compiler-v2/tests/checking/typing/constant_allowed_but_not_supported.exp
    V2 does not complain about the use of const names in other consts.

In PR #14578 I'm adding a new test case

  • third_party/move/move-compiler/tests/move_check/typing/recursive_constant.exp
  • third_party/move/move-compiler-v2/tests/checking/typing/recursive_constant.exp
    which shows totally unexpected code generated by V2 in the case of recursive constants.

This needs to be fixed.

@rahxephon89
Copy link
Contributor

Instead of not allowing it, I am wondering whether we could check recursive use of other constants?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants