Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-compiler-v2] #[expected_failure] with invalid location yields no error in V2 #14635

Open
brmataptos opened this issue Sep 14, 2024 · 1 comment
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

🐛 Bug

See test output

  • third_party/move/move-compiler/tests/move_check/unit_test/other_failures_invalid_location.unit_test.exp
  • third_party/move/move-compiler-v2/tests/unit_test/test/other_failures_invalid_location.exp
    Note that V1 shows errors for lines 26, 30, 34, 38, such as:
error[E10003]: invalid attribute value
   ┌─ tests/move_check/unit_test/other_failures_invalid_location.move:26:38
   │
26 │     #[expected_failure(vector_error, location=x)]
   │                                      ^^^^^^^^^^
   │                                      │        │
   │                                      │        Expected a module identifier, e.g. 'std::vector'
   │                                      Invalid value in attribute assignment

Compiler V2 misses these errors.

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label or comment - otherwise this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Oct 30, 2024
@wrwg wrwg added stale-exempt Prevents issues from being automatically marked and closed as stale and removed Stale labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants