Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-compiler-v2] Compiler V2 misses key ability errors, with an edited test yields a "bug" #14629

Open
brmataptos opened this issue Sep 14, 2024 · 1 comment
Labels
bug Something isn't working compiler-errormessage compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

🐛 Bug

Compiler V1 catches some "missing ability key" errors which are missed by Compiler V2:

  • third_party/move/move-compiler/tests/move_check/typing/pack_constraint_not_satisfied.exp
  • third_party/move/move-compiler-v2/tests/ability-check/v1-typing/pack_constraint_not_satisfied.exp

Reducing the test to try to eliminate error shadowing:

  • third_party/move/move-compiler/tests/move_check/typing/pack_constraint_not_satisfied2.exp
  • third_party/move/move-compiler-v2/tests/ability-check/v1-typing/pack_constraint_not_satisfied2.exp
    yields a compiler "bug" from V2 instead of the expected "key" errors:
Diagnostics:
bug: unexpected type: _
  ┌─ tests/ability-check/v1-typing/pack_constraint_not_satisfied2.move:6:9
  │
6 │     fun t0() {
  │         ^^
@wrwg
Copy link
Contributor

wrwg commented Oct 31, 2024

Might be fixed by now as something in this area was recently fixed.

@brmataptos brmataptos added the stale-exempt Prevents issues from being automatically marked and closed as stale label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler-errormessage compiler-v2-stable compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: For Grabs
Development

No branches or pull requests

2 participants