Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reaper): forkExec error no such file or directory & prometheus exit error #178

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(reaper): forkExec error no such file or directory & prometheus exit error #178

wants to merge 7 commits into from
+181 −76

Conversation

qianlongzt
Copy link
Contributor

@qianlongzt qianlongzt commented Oct 12, 2024 •
edited
Loading

  1. fix Reaper doesn't look for supercronic in PATH #177
  2. run reaper test in docker container
  3. use bats-action to install bats-core and bats-assert ...
  4. fix Graceful stopping fails with prometheus enabled #173

@qianlongzt qianlongzt mentioned this pull request Oct 12, 2024
Open
@qianlongzt
Copy link
Contributor Author

@UserNotFound Is there anything I can do? There's no progress.

@UserNotFound
Copy link
Member

UserNotFound commented Oct 18, 2024 •
edited
Loading

Can you add a test for this case?

Also, i'm not sure if it would be related, but there's another issue listed related to this feature, if you could patch that here in this PR is would streamline review and release. #173

@qianlongzt
Copy link
Contributor Author

@UserNotFound

I added the test and ran the reaper test in Docker
The bats-core action needs to be trusted
bats-core/[email protected] is not allowed to be used in aptible/supercronic.

The Prometheus error may not be related; the old version has the same error.
https://github.com/aptible/supercronic/releases/download/v0.2.30/supercronic-linux-amd64

@qianlongzt qianlongzt changed the title fix(reaper): forkExec error no such file or directory fix(reaper): forkExec error no such file or directory & prometheus exit error Oct 19, 2024
@qianlongzt
Copy link
Contributor Author

@UserNotFound i fixed prometheus http server closed error

@qianlongzt
Copy link
Contributor Author

@UserNotFound Is there anything I can do? There's no progress.

1 similar comment
@qianlongzt
Copy link
Contributor Author

@UserNotFound Is there anything I can do? There's no progress.

@UserNotFound
Copy link
Member

@UserNotFound Is there anything I can do? There's no progress.

This review is being prioritized within our team, but I don't have any information at the moment as to when that will occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krallin krallin Awaiting requested review from krallin krallin is a code owner

@UserNotFound UserNotFound Awaiting requested review from UserNotFound UserNotFound is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reaper doesn't look for supercronic in PATH Graceful stopping fails with prometheus enabled
2 participants
@qianlongzt @UserNotFound