统一黑白名单，支持规则优先级、搜索、多选管理 #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 12, 2021 08:13
支持搜索 多选管理(删除、恢复、已读) 显示接收SIM卡(subid) 多行显示 识别信息中网址
之前使用changeCursor()，在一些场景下，界面的数据不会自动更新（如查询后回到主界面）
apsun
requested changes
Dec 12, 2021
There was a problem hiding this comment.
Hi, thanks for the PR! I love the idea of these features, I would have implemented them myself but never had the time. That said, this change is 1.5k LoC and touches 40 code files, which makes it quite difficult to review. Could you please split up the PR into smaller, separate PRs (one for each feature)? That will make the code much easier to understand. Thanks!
|
这些代码也是多年使用NekoSMS，因为自己的需求而积累下来的更改。所以影响范围较大。 |
|
因累计改动较多，待后续分解后重新PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【目标】
被拦截的短信很多时候我们也希望能进行方便的管理，比如进行查询，删除某些特定的短信。因此对相关功能进行了补充。
【主要更新点】
统一黑白名单，支持规则优先级 (fixes #54 )
支持按发送者或消息内容进行搜索
新增多选管理(删除、恢复、已读)
显示接收SIM卡(subid)
规则及短信调整为多行显示（在列表界面即可完整查看）(fixes #82 )
识别信息中网址，链接可点击跳转