Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Optimize permission checks #537

Open
ccremer opened this issue Apr 18, 2023 · 0 comments
Open

Refactor: Optimize permission checks #537

ccremer opened this issue Apr 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ccremer
Copy link
Contributor

ccremer commented Apr 18, 2023

Summary

As maintainer
I want to eliminate some permission checks
So that reduce complexity of the app

Context

With newer features in the control-api even the basic user gets more and more permissions.
See RBAC permission for a list of permissions.

In the Portal, we do a lot of permission checking, e.g. can-i list organizations or can-i update billingentity. Based on those permission query results, we enable/disable menus, buttons or change the behavior of components.

However, this checking is unnecessary if even the most basic user, including users from foreign IDPs, can do common operations anyway by just being allowed to log in to the control-api. If that's indeed the case, we can eliminate a lot of the permission checking in the code, thereby simplifying and reducing the complexity in the code.

Note: This isn't about eliminating all permission checks. We still need checks to determine whether we're Admin of a certain Organization or Billing entity for example. It's primarily about reducing the generic ones, e.g. list or create permissions.

Out of Scope

There is another issue to discuss how we're doing permission checks. This issue here discusses which permissions to check.

Further links

Acceptance Criteria

No response

Implementation Ideas

No response

@ccremer ccremer added the enhancement New feature or request label Apr 18, 2023
@ccremer ccremer changed the title Optimize permission checks Refactor: Optimize permission checks Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant