-
Notifications
You must be signed in to change notification settings - Fork 12
Support custom APPSODY_MOUNT separator #31
Comments
cc @kewegner |
@gireeshpunathil why would the controller need this? The controller does not run docker commands. |
The controller uses the APPSODY_MOUNTS environment variable in the case there are no APPSODY_WATCH_DIRS. If we change the value of APPSODY_MOUNTS to have something other than ";" as a separator, the logic in the controller would have to change, because it splits on ";". See line 269 of main.go. |
Ok, so to clarify, adopting the docker --mount syntax to allow colons does NOT need controller changes. However if as a result we change the APPSODY_MOUNTS separator, then yes the controller needs to support this. |
When this issue is done, we would also want to consider the separator for the APPSODY_WATCH_DIRs and the APPSODY_WATCH_IGNOREDIRS (PATHS). Since those are in a list using ';' as the separator. |
We should address #31 at the same time. Also the changes we made for single mount testing might be affected. |
I have started to code this up and will work with @rykal-nate prior to Friday. |
We expect more changes in this area and would prefer to get a clear design agreed across various components - stacks, cli, controller etc. Other priorities have not allowed us to focus on this use case as much. I've closed 2 PRs related to this, but once we have more clarity on how we want to enable this use case, we can re-open this PR again. |
Is your feature request related to a problem? Please describe.
Please refer to appsody/appsody#31
Describe the solution you'd like
Please refer to appsody/appsody#31
Describe alternatives you've considered
Please refer to appsody/appsody#31
Additional context
appsody/appsody#338 is raised in appsody, a similar change in controller in this repo would compliment it
The text was updated successfully, but these errors were encountered: