From a6b7644a2fc09f4c80a338727fff68d216179e3f Mon Sep 17 00:00:00 2001 From: Abhishek Pandey <66054987+a6hishekpandey@users.noreply.github.com> Date: Tue, 17 Sep 2024 12:41:03 +0530 Subject: [PATCH] fix: show bindings sub-menu position has been displaced (#36340) ## Description Issue: Show bindings sub-menu position has been displaced. This PR addresses issue #36285 by removing the extra space from `left` style property of EntityProperties.tsx as Explorer div has position as relative and entity properties container is inside the Explorer div, so we need to calculate the value of `left` style based on the Explorer div. Fixes #36285 ## Automation /ok-to-test tags="@tag.IDE" ### :mag: Cypress test results > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **Bug Fixes** - Simplified the positioning of UI components by removing unnecessary dependencies, which may improve layout consistency. --- .../src/pages/Editor/Explorer/Entity/EntityProperties.tsx | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx b/app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx index 8a5619f47c2..19b9d056b6c 100644 --- a/app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx +++ b/app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx @@ -13,10 +13,7 @@ import { Button } from "@appsmith/ads"; import { getEntityProperties } from "ee/pages/Editor/Explorer/Entity/getEntityProperties"; import store from "store"; import { ENTITY_TYPE } from "entities/DataTree/dataTreeFactory"; -import { - APP_SIDEBAR_WIDTH, - DEFAULT_EXPLORER_PANE_WIDTH, -} from "constants/AppConstants"; +import { DEFAULT_EXPLORER_PANE_WIDTH } from "constants/AppConstants"; import { BOTTOM_BAR_HEIGHT } from "components/BottomBar/constants"; const BindingContainerMaxHeight = 300; @@ -119,8 +116,7 @@ export function EntityProperties() { ref.current.style.top = top - EntityHeight + "px"; ref.current.style.bottom = "unset"; } - ref.current.style.left = - APP_SIDEBAR_WIDTH + DEFAULT_EXPLORER_PANE_WIDTH + "px"; + ref.current.style.left = DEFAULT_EXPLORER_PANE_WIDTH + "px"; } }, [entityId]);