Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into the least common ancestor algorithm when merging subparsers #157

Open
paulgazz opened this issue Sep 10, 2021 · 0 comments
Open

Comments

@paulgazz
Copy link
Member

paulgazz commented Sep 10, 2021

There may be a bug in an optimization that attempts to avoid inserting static conditional nodes around shared semantic values by computing the least common ancestor of mergeable subparsers. This wouldn't affect correctness, but could cause additional static conditional nodes to be inserted when not needed.

Should be fixable in the subparser merge function by moving the StackFrame s = ... into the for loop below it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant