This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Implement access control for baggage items via key properties #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Writeup about context passing style guideline Polished version of what we had in slashmo/gsoc-swift-tracing#12 * Update README.md Co-authored-by: Moritz Lang <[email protected]> * Update README.md Co-authored-by: Moritz Lang <[email protected]> * Update README.md Co-authored-by: Moritz Lang <[email protected]> * Update README.md Co-authored-by: Moritz Lang <[email protected]> * Update README.md Co-authored-by: Moritz Lang <[email protected]> * Update README.md Co-authored-by: Moritz Lang <[email protected]> * Update README.md Co-authored-by: Moritz Lang <[email protected]>
slight formatting fix for readme
* Add license header validation script * Add naming validation script
=readme bolden the primary usage style
Add installation instructions 📖
fix repo url
…ts for small contexts
+simple benchmarks to have a gut feeling how mutating and the CoW cos…
WIP #7: on holding baggage in framework protocols
Update instalation instructions for 0.2.0 📖
* adding SSWG meeting notes * Update README.md * Update README.md Co-authored-by: Moritz Lang <[email protected]> Co-authored-by: Moritz Lang <[email protected]>
Small updates in context passing guidelines
Downgrade Swift version to 5.0
Prefix Benchmark targets to avoid name clashes
!logging #30 logger need not be { set }
Semantically helpfully named empty baggage factory functions #26
remove and ignore Package.resolved
slashmo
approved these changes
Oct 7, 2020
| @@ -185,6 +185,7 @@ extension Baggage { | |||
| return self._storage.count | |||
| } | |||
|
|
|||
| /// Returns true if the baggage has no items stored. | |||
|
|
||
| public enum ForEachAccessType: Int, Hashable { | ||
| /// Access all accessible values (i.e. `public` and `publicExceptLogging` values; `private` values are skipped) | ||
| case allPublic = 8 |
There was a problem hiding this comment.
Would it make sense to add a comment on why you chose 8 here? I'm guessing it's to have a bit of headroom when adding more cases in the future.
There was a problem hiding this comment.
okey will do -- it's pretty sneaky, it matches up with the values used in the Access enum but "inverse"
Yes 8 because to leave space for other values if ever necessary
| } | ||
|
|
||
| extension Baggage { | ||
| public typealias AccessPolicy = BaggageAccessPolicy |
There was a problem hiding this comment.
This is an interesting pattern to work around not being able to nest types in protocols, also noticed you added this for Baggage.Key 👀👍
There was a problem hiding this comment.
Yeah, I do this often actually. Not everyone loves it, but for those two types it's nice since it's all Baggage.[complete] then :)
|
|
||
| extension AnyBaggageKey: CustomStringConvertible { | ||
| public var description: String { | ||
| return "AnyBaggageKey(\(self.name), access: \(self.access))" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access control for baggage items.
This is the low level piece to resolve apple/swift-service-context#2