Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Vision #2900

Open
felswa opened this issue Oct 2, 2024 · 2 comments
Open

Support for Vision #2900

felswa opened this issue Oct 2, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@felswa
Copy link

felswa commented Oct 2, 2024

Hi. In certain places like Source/NIOFileSystem/FileSystem there is:

#if os(macOS) || os(iOS) || os(tvOS) || os(watchOS) || os(Linux) || os(Android)

Can you please add os(visionOS) to this across the project. Thanks.
@Lukasa
Copy link
Contributor

Lukasa commented Oct 2, 2024

@glbrntt we should replace the Apple OSes with canImport(Darwin)

@glbrntt glbrntt added the good first issue Good for newcomers label Oct 2, 2024
@glbrntt
Copy link
Contributor

glbrntt commented Oct 2, 2024

The #if os(...) guards in all of the file system code were to work around Swift System not knowing about visionOS (see: #2636).

However, support for visionOS was added in Swift System 1.3.0.

I think the fix here should be to:

  1. remove the top-level #if os(macOS) || os(iOS) || os(tvOS) || os(watchOS) || os(Linux) || os(Android) from the file system code,
  2. bump the minimum version of swift-system required to 1.3.0
  3. remove the conditional dependency on swift-system from Package.swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lukasa @glbrntt @felswa