Compiling NIOFileSystem on Mac Catalyst: No such module 'SystemPackage'

[makaGeorge]

Expected behavior

Build with no errors

Actual behavior

No such module 'SystemPackage'

Steps to reproduce

1. Add NIOFileSystem to an empty iOS Xcode project. Select the Mac Catalyst platform
2. Build

First noticed when building a project using Vapor, which uses swift-nio. Found out I couldn't build for MacCatalyst so I tried an empty project and the same happens.

If possible, minimal yet complete reproducer code (or URL to code)

SwiftNIO version/commit hash

2.69.0

System & version information

Swift 5.10 and Swift 6 (Xcode 16 beta 4)

[Lukasa]

Can you please attach a complete build log?

[makaGeorge]

Build testrv_2024-08-19T09-46-54.txt

Here's the build log. Thanks!

[Lukasa]

It seems that _NIOFileSystem's System dependency is not being picked up:

    Target 'NIOFileSystem' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIOAtomics' in project 'swift-nio'
        ➜ Explicit dependency on target 'NIOConcurrencyHelpers' in project 'swift-nio'
        ➜ Explicit dependency on target '_NIOBase64' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIODarwin' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIOLinux' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIOWindows' in project 'swift-nio'
        ➜ Explicit dependency on target '_NIODataStructures' in project 'swift-nio'
        ➜ Explicit dependency on target 'NIOCore' in project 'swift-nio'
        ➜ Explicit dependency on target 'NIOPosix' in project 'swift-nio'
        ➜ Explicit dependency on target '_NIOFileSystem' in project 'swift-nio'
        ➜ Explicit dependency on target 'DequeModule' in project 'swift-collections'
        ➜ Explicit dependency on target 'Atomics' in project 'swift-atomics'

@glbrntt what is the intention of having constrained the use of the dependency?

[Lukasa]

In the meantime, macCatalyst should be added to the list linked above.

[glbrntt]

It seems that _NIOFileSystem's System dependency is not being picked up:

    Target 'NIOFileSystem' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIOAtomics' in project 'swift-nio'
        ➜ Explicit dependency on target 'NIOConcurrencyHelpers' in project 'swift-nio'
        ➜ Explicit dependency on target '_NIOBase64' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIODarwin' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIOLinux' in project 'swift-nio'
        ➜ Explicit dependency on target 'CNIOWindows' in project 'swift-nio'
        ➜ Explicit dependency on target '_NIODataStructures' in project 'swift-nio'
        ➜ Explicit dependency on target 'NIOCore' in project 'swift-nio'
        ➜ Explicit dependency on target 'NIOPosix' in project 'swift-nio'
        ➜ Explicit dependency on target '_NIOFileSystem' in project 'swift-nio'
        ➜ Explicit dependency on target 'DequeModule' in project 'swift-collections'
        ➜ Explicit dependency on target 'Atomics' in project 'swift-atomics'

@glbrntt what is the intention of having constrained the use of the dependency?

swift-system didn't compile for visionOS so we dropped support for it in file system so that NIO could still be built (53965cc)

That may well have changed so we might be able to remove the condition entirely.

[glbrntt]

swift-system supports visionOS from 1.3.0 and removing the condition from NIOs manifest works for visionOS.

Unfortunately swift-system doesn't support macCatalyst. I opened a PR to add support: apple/swift-system#193