copy-paste error in NIOTSConnectionChannel getOption0 allowLocalEndpointReuse

[vvuk]

Looks like a copy-paste mistake here:

swift-nio-transport-services/Sources/NIOTransportServices/NIOTSConnectionChannel.swift

Lines 320 to 323 in e7f5278

	case is NIOTSChannelOptions.Types.NIOTSEnablePeerToPeerOption:
	self.enablePeerToPeer = value as! NIOTSChannelOptions.Types.NIOTSEnablePeerToPeerOption.Value
	case is NIOTSChannelOptions.Types.NIOTSAllowLocalEndpointReuse:
	self.allowLocalEndpointReuse = value as! NIOTSChannelOptions.Types.NIOTSEnablePeerToPeerOption.Value

allowLocalEndpointReuse is being set to the value of NIOTSEnablePeerToPeerOption, not itself.

Though it might not really matter, because from everything I can tell allowLocalEndpointReuse seems to be completely broken on NWListener (ref https://developer.apple.com/forums/thread/129452).

[Lukasa]

Good catch! Even if it’s not working well, we’d take a fix to make it correct here.

[AgentFeeble]

It looks like a similar issue slipped through in StateManagedNWConnectionChannel

https://github.com/apple/swift-nio-transport-services/blob/251e9e76134570f0cc5c21e5c6ff3ccb247472ab/Sources/NIOTransportServices/StateManagedNWConnectionChannel.swift#L540C9-L541C113

case is NIOTSChannelOptions.Types.NIOTSAllowLocalEndpointReuse:
    self.allowLocalEndpointReuse = value as! NIOTSChannelOptions.Types.NIOTSEnablePeerToPeerOption.Value

It won't make any difference as long as both NIOTSEnablePeerToPeerOption.Value and NIOTSAllowLocalEndpointReuse.Value are Bools, but it's probably better to fix it anyway for consistency.

[Lukasa]

Agreed. Do you feel like making a patch?

[AgentFeeble]

Sure, I'll submit a PR when I get a chance.