-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup all warnings in 5.9 build #1125
Comments
There's a lot of these annoying ones:
due to Never gaining a Codable conformance as well |
Hey @ktoso! What would be the best strategy to address Never warnings? I can think about two solutions:
|
Tbh I think we can bump the platform requirement, would you want to do that? :) |
Yeah, I would like to do that with some of other warnings as well. 🙂 |
**Motivation:** Currently, project contains quite amount of shadowed generics warnings. All this warnings will become errors with Swift 6. **Modifications:** Each warning occurency is updated to use slightly different type parameters name. **Result:** - Partially addresses apple#1125
FYI, I have opened one PR and have another one pending 😉 |
Thanks for the ping, I'll give it a look |
* chore: bump minimal macOS version * fix: resolve Swift 6 warnings - shadowing generics **Motivation:** Currently, project contains quite amount of shadowed generics warnings. All this warnings will become errors with Swift 6. **Modifications:** Each warning occurency is updated to use slightly different type parameters name. **Result:** - Partially addresses #1125 * fix: removing duplicated function * fix: non-throwing closure in rethrow func * fix: Swift Backtrace removal * fix: providing default value in case of optional * fix: using fulfillment in async tests * fix: removing convenience keyword from Actor init * fix: removing await keyword * fix: remove duplicated entry in dict * fix: remove non-required keyword in import * fix: remove non-required await keyword in tests * fix: use removeAll() to mute warning * fix: addressing warnings with vars * Unused vars are replaced with '_' * Not mutated vars are updated to be 'let' * update base swift version in images * formatting --------- Co-authored-by: Konrad `ktoso` Malawski <[email protected]>
We have a lot of self induced "deprecation warnings" because we use the runtime that people should not be touching.
The text was updated successfully, but these errors were encountered: