Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Detect source breaking changes #435

Open
lorentey opened this issue Nov 18, 2024 · 1 comment
Open

[CI] Detect source breaking changes #435

lorentey opened this issue Nov 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@lorentey
Copy link
Member

It would be nice to have a source compatibility check, but this project currently has the api-breakage-check "soundness" check disabled. Evaluate this check to see if it usable, and enable it if so.

Basic requirements:

  1. We need to compare against a baseline that is configurable on a per-branch basis.
  2. Automated source compatibility checks are extremely prone to false positives. Therefore, we need a reliable way to suppress any and all failures.
@lorentey lorentey added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 18, 2024
@FranzBusch
Copy link
Member

It would be nice to have a source compatibility check, but this project currently has the api-breakage-check "soundness" check disabled. Evaluate this check to see if it usable, and enable it if so.

FWIW, we have this check enabled on all of our repos.

The reality is that this is actually an ABI breaking checker and not an API one but that's okay for us. We sometimes do get false-positives but we just admin merge over them once we come to the conclusion that this is in fact not an API breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants