Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension produces error on install using MacOS #1

Open
redeux opened this issue Feb 3, 2024 · 5 comments
Open

Extension produces error on install using MacOS #1

redeux opened this issue Feb 3, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@redeux
Copy link

redeux commented Feb 3, 2024

When installing your extension v0.15.0 on MacOS I received the following error. It does appear that the extension was installed per the CLI message and I can see it in the VSCode extensions list.

~ code --install-extension pkl-vscode-0.15.0.vsix 
Installing extensions...
(node:25132) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Electron --trace-deprecation ...` to show where the warning was created)
Extension 'pkl-vscode-0.15.0.vsix' was successfully installed.

System information:

~ system_profiler SPSoftwareDataType SPHardwareDataType
Software:

    System Software Overview:

      System Version: macOS 14.2.1 (23C71)
      Kernel Version: Darwin 23.2.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Secure Virtual Memory: Enabled
      System Integrity Protection: Enabled
      Time since boot: 2 days, 22 hours, 24 minutes

Hardware:

    Hardware Overview:

      Model Name: MacBook Air
      Model Identifier: Mac14,2
      Model Number: Z15S000D1LL/A
      Chip: Apple M2
      Total Number of Cores: 8 (4 performance and 4 efficiency)
      Memory: 16 GB
      System Firmware Version: 10151.61.4
      OS Loader Version: 10151.61.4
      Activation Lock Status: Enabled
@holzensp holzensp added the good first issue Good for newcomers label Feb 8, 2024
@holzensp
Copy link

holzensp commented Feb 8, 2024

Thank you for the report. This is a deprecation warning, rather than an error. It needs addressing, but it's not broken.

@redeux
Copy link
Author

redeux commented Feb 8, 2024

It appears this warning is actually an upstream VSCode issue tracked here: microsoft/vscode#82524

Based on my reading of the upstream issue, this warning will not be surfaced once the extension is installed via the VSCode marketplace rather than the CLI.

@holzensp
Copy link

holzensp commented Feb 9, 2024

Thank you for digging that up, @redeux. We are working on submitting to the marketplace. (I'll keep this issue open to track that submission)

@redeux
Copy link
Author

redeux commented Feb 9, 2024

Sounds good. If there's anything I can do to help please let me now. Not necessarily with getting the extension into the marketplace because I assume Apple would need to handle that internally, but if there are other roadmap items or issues, I'm happy to lend a hand with the project.

@holzensp
Copy link

holzensp commented Feb 9, 2024

Well, if you fancy writing an LSP... jk

Keep an eye on the Issues. I'm hoping to put a bunch of "Help Wanted" issues out soon. Most of those will be somewhat larger items. That said; this is open source now. If there is anything you see that you feel comfortable with, hop on it! Also, keep using it and file new issues for anything that irks you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants