Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::filesystem::path in Platform.h #11443

Open
xis19 opened this issue Jun 5, 2024 · 7 comments
Open

Use std::filesystem::path in Platform.h #11443

xis19 opened this issue Jun 5, 2024 · 7 comments

Comments

@xis19
Copy link
Collaborator

xis19 commented Jun 5, 2024

Since C++17 had introduced built-in standard path library, it is unnecessary to have custom path manipulation code to FoundationDB.

@yunimoo
Copy link

yunimoo commented Aug 2, 2024

Hi, I'm interested in this issue and wanted to reach out to see if it was fine if I can work on this?

@xis19
Copy link
Collaborator Author

xis19 commented Aug 2, 2024

@yunimoo You can start contributing by cloning the repository and create pull requests.

@giorgiozoppi
Copy link

I also can help

@yunimoo
Copy link

yunimoo commented Aug 8, 2024

I also can help

Thank you. I have some work(?) done on it and can publish a draft PR when I get the chance. Not sure if I'm going in the right direction but could use some guidance / suggestions

@giorgiozoppi
Copy link

Sure, happy to lint and review you code using C++ code guidelines.

@giorgiozoppi
Copy link

I have a question @xis19 are u the mantainer now?

@xis19
Copy link
Collaborator Author

xis19 commented Aug 8, 2024

I have a question @xis19 are u the mantainer now?

Not really but feel free to ask me anything. I will redirect you to corresponding people if I can't answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants