Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iSTFT #2330

Open
ari-ruokamo opened this issue Sep 1, 2024 · 3 comments
Open

Support for iSTFT #2330

ari-ruokamo opened this issue Sep 1, 2024 · 3 comments
Labels
feature request Functionality does not currently exist, would need to be created as a new feature (type)

Comments

@ari-ruokamo
Copy link

ari-ruokamo commented Sep 1, 2024

🌱 Describe your Feature Request

I am trying to convert a Music Source Separation (MSS) Pytorch models using CoreMLTools using this guide https://apple.github.io/coremltools/docs-guides/source/convert-pytorch-workflow.html to later integrate with my inference implementation in Swift. The model uses both torch.stft and torch.istft in its functionality. The tracing stops in error of absence of iSTFT conversion functionality.

How can this feature be used?

Inverse STFT is essential functionality in MSS and other audio applications.

Describe alternatives you've considered

None yet, to work around this any pointers are appreciated.

@ari-ruokamo ari-ruokamo added the feature request Functionality does not currently exist, would need to be created as a new feature (type) label Sep 1, 2024
@YifanShenSZ
Copy link
Collaborator

Our complex expert @junpeiz

Are we able to convert them given current op set, or do we need to file feature request to Core ML framework?

@junpeiz
Copy link
Collaborator

junpeiz commented Sep 6, 2024

There is a iSTFT implementation here: #2029

It should work for most cases, and we haven't checked in the code because there are some CI failures on the Intel machine.

@ari-ruokamo
Copy link
Author

There is a iSTFT implementation here: #2029

It should work for most cases, and we haven't checked in the code because there are some CI failures on the Intel machine.

Thank you. Did not realize to peek into PRs - will definitely look into this one and try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Functionality does not currently exist, would need to be created as a new feature (type)
Projects
None yet
Development

No branches or pull requests

3 participants