Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

blablacar fork #9

Open
Andrei-Pozolotin opened this issue Jun 14, 2016 · 6 comments
Open

blablacar fork #9

Andrei-Pozolotin opened this issue Jun 14, 2016 · 6 comments

Comments

@Andrei-Pozolotin
Copy link

we found changes made by Arnaud Lemaire rather useful:
https://github.com/blablacar/acserver
blablacar/dgr#174

  1. are those too much for you to pull back?

  2. on the other hand we found current acserver command line interface
    inflexible from the expansion, modification and usage point of view:

Usage of /usr/bin/acserver:
acserver SERVER_NAME ACI_DIRECTORY TEMPLATE_DIRECTORY USERNAME PASSWORD
  • can you please use named (not positional) parameters?
  • can you allow "unexpected" -flag or --flag for expansion by a fork?
@cgonyeo
Copy link
Member

cgonyeo commented Jun 16, 2016

  1. Sure, I'd be happy to accept those changes if @n0rad has time to make a PR.

  2. I could quickly change acserver to use cobra for command line parsing, this would give it similar semantics to rkt and acbuild. Would that be fine?

@n0rad
Copy link
Contributor

n0rad commented Jun 16, 2016

We would like to switch our production store to a improved version of acserver.

I was not about to do PR because it will change most of the code and require a build script to

  • use cobra
  • embed template
  • reorganize storage for a more scalable directory structure
  • and few other things

But I can still propose it if you want.

@jonboulle
Copy link
Contributor

I don't want to speak for dgonyeo since he'd be reviewing but I would love
to have your changes upstreamed :-)

On 17 June 2016 at 00:34, Arnaud Lemaire [email protected] wrote:

We would like to switch our production store to a improved version of
acserver.

I was not about to do PR because it will change most of the code and
require a build script to

  • use cobra
  • embed template
  • reorganize storage for a more scalable directory structure
  • and few other things

But I can still propose it if you want.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ACewN8qtL2XDDFFDvrAGgn5LZw1HKBm_ks5qMc9hgaJpZM4I1jF7
.

@cgonyeo
Copy link
Member

cgonyeo commented Jun 17, 2016

Yup, what @jonboulle said.

@Andrei-Pozolotin
Copy link
Author

@n0rad we are ready to test your PR :-)

@n0rad
Copy link
Contributor

n0rad commented Jun 20, 2016

Give me some time, I'm overloaded

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants