Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent introspection query errors in rover dev #1868

Open
dandersonhall opened this issue Mar 6, 2024 · 1 comment
Open

Intermittent introspection query errors in rover dev #1868

dandersonhall opened this issue Mar 6, 2024 · 1 comment
Labels
bug 🐞 triage issues and PRs that need to be triaged

Comments

@dandersonhall
Copy link

Description

Using rover dev and getting regular error messages like
error[E004]: error sending request for url (http://localhost:4001/): connection error: Connection reset by peer (os error 54)
and
error[E004]: error sending request for url (http://localhost:4002/): connection closed before message completed

This causes the router instance to stop and not restart until the next introspection query.

Steps to reproduce

Run rover dev --supergraph-config supergraph.yaml --polling-interval=5
where supergraph.yaml looks like

subgraphs:
  subgraph1:
    routing_url: http://localhost:4001/
    schema:
      subgraph_url: http://localhost:4001/
  subgraph2:
    routing_url: http://localhost:4002/
    schema:
      subgraph_url: http://localhost:4002/

Expected result

Rover dev should handle the errors (or at least retry) before removing the subgraph from the session. Investigationg have shown that the subgraph is sending a connection reset message to rover but this causes rover to fail the subgraph straight away even though the next request would succeed.

Environment

Version: 0.22.0
Install Location: /Users//.rover/bin/rover
OS: Mac OS 14.2.1 [64-bit]
Shell: /bin/zsh

@dandersonhall dandersonhall added bug 🐞 triage issues and PRs that need to be triaged labels Mar 6, 2024
@jonathanrainer
Copy link
Contributor

Hi @dandersonhall, apologies for the length of time taken to reply. We have a PR open that I believe would fix this issue, is there any chance you could have a go building Rover and trying it out in your specific situation? No guarantees obviously but it would be good to know if it helps :)

PR in question: #1936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 triage issues and PRs that need to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants