Network Transport send should not be async

It returns an AsyncThrowingStream that you await for results. But the send function should return that stream synchronously.

Author: AnthonyMDev

apollo-ios/Sources/Apollo/Interceptors/CacheInterceptor.swift

@@ -18,7 +18,11 @@ public protocol CacheInterceptor: Sendable {
 
 public struct DefaultCacheInterceptor: CacheInterceptor {
 
-  let store: ApolloStore
+  public let store: ApolloStore
+
+  public init(store: ApolloStore) {
+    self.store = store
+  }
 
   public func readCacheData<Query: GraphQLQuery>(
     for query: Query

apollo-ios/Sources/Apollo/Interceptors/MaxRetryInterceptor.swift

@@ -3,7 +3,6 @@ import Foundation
 import ApolloAPI
 #endif
 
-#warning("TODO: remove unchecked when making interceptor functions async.")
 /// An interceptor to enforce a maximum number of retries of any `HTTPRequest`
 public actor MaxRetryInterceptor: ApolloInterceptor, Sendable {
 

apollo-ios/Sources/Apollo/NetworkTransport.swift

@@ -21,7 +21,7 @@ public protocol NetworkTransport: AnyObject, Sendable {
     cachePolicy: CachePolicy,
     contextIdentifier: UUID?,
     context: (any RequestContext)?
-  ) async throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error>
+  ) throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error>
 
 }
 

apollo-ios/Sources/Apollo/RequestChainNetworkTransport.swift

@@ -113,9 +113,9 @@ public final class RequestChainNetworkTransport: NetworkTransport, Sendable {
   public func send<Operation: GraphQLOperation>(
     operation: Operation,
     cachePolicy: CachePolicy,
-    contextIdentifier: UUID?,
-    context: (any RequestContext)?
-  ) async throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error> {
+    contextIdentifier: UUID? = nil,
+    context: (any RequestContext)? = nil
+  ) throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error> {
     let request = self.constructRequest(
       for: operation,
       cachePolicy: cachePolicy,

apollo-ios/Sources/ApolloWebSocket/SplitNetworkTransport.swift

@@ -53,15 +53,15 @@ extension SplitNetworkTransport: NetworkTransport {
     cachePolicy: CachePolicy,
     contextIdentifier: UUID? = nil,
     context: (any RequestContext)? = nil
-  ) async throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error> {
+  ) throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error> {
     if Operation.operationType == .subscription {
-      return try await webSocketNetworkTransport.send(
+      return try webSocketNetworkTransport.send(
         operation: operation,
         cachePolicy: cachePolicy,
         contextIdentifier: contextIdentifier,
         context: context)
     } else {
-      return try await uploadingNetworkTransport.send(
+      return try uploadingNetworkTransport.send(
         operation: operation,
         cachePolicy: cachePolicy,
         contextIdentifier: contextIdentifier,

apollo-ios/Sources/ApolloWebSocket/WebSocketTransport.swift

@@ -451,7 +451,7 @@ extension WebSocketTransport: NetworkTransport {
     cachePolicy: CachePolicy,
     contextIdentifier: UUID? = nil,
     context: (any RequestContext)? = nil
-  ) async throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error> {
+  ) throws -> AsyncThrowingStream<GraphQLResult<Operation.Data>, any Error> {
     if let error = self.error {
       return AsyncThrowingStream.init {
         throw error