Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the dialogue plugin to Kotlin #381

Open
garyttierney opened this issue Mar 27, 2018 · 2 comments
Open

Port the dialogue plugin to Kotlin #381

garyttierney opened this issue Mar 27, 2018 · 2 comments
Assignees
Labels
kotlin plugin ruby-to-kotlin Part of the port from ruby to kotlin

Comments

@garyttierney
Copy link
Contributor

Tracker issue for checklist item in #338

@garyttierney garyttierney added plugin kotlin ruby-to-kotlin Part of the port from ruby to kotlin labels Mar 27, 2018
@Major-
Copy link
Member

Major- commented Mar 27, 2018

This involves fixing some known bugs that exist in the ruby version (#133, possibly #383). The statement dialogue interface ids currently used are also a bit suspect.

This should also close #160.

@Major-
Copy link
Member

Major- commented Apr 4, 2018

The current plan for the dialogue system in Kotlin is to write a DSL backed by coroutines, where dialogue text is interleaved with code, and various actions (like waiting on the player to 'Click here to continue', select an option from a list, etc) block at the couroutine/fibre level. This removes a significant amount of complexity from the current implementation, effectively flattening everything into one long conversation (rather than the nested dialogues, each with their own separate close/continue callbacks).

Because of the effort involved in this rewrite (more like a completely different plugin), it's been deselected from the port to kotlin project. This one will be one of our first tasks post-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kotlin plugin ruby-to-kotlin Part of the port from ruby to kotlin
Projects
None yet
Development

No branches or pull requests

2 participants