Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CSS #114

Closed
4 tasks done
apmwebdev opened this issue Feb 5, 2024 · 1 comment · Fixed by #124
Closed
4 tasks done

Clean up CSS #114

apmwebdev opened this issue Feb 5, 2024 · 1 comment · Fixed by #124
Assignees
@apmwebdev
Labels
cleanup Too small to be a true "refactor," but same idea ui UI-specific issues, often CSS related
Milestone
Alpha release

Comments

@apmwebdev
Copy link
Owner

apmwebdev commented Feb 5, 2024 •
edited
Loading

  • Remove commented out code
  • Use svh or dvh instead of vanilla vh for min-height of body to account for mobile
  • Remove unneeded styles (e.g., redundant width: 100%, display: flex with no need for flexbox layout, etc.)
  • Make sure CSS file names correspond to the item they apply to (e.g., "status" might be better as "progress")
  • Switch from hsl to oklch color
@apmwebdev apmwebdev added cleanup Too small to be a true "refactor," but same idea ui UI-specific issues, often CSS related labels Feb 5, 2024
@apmwebdev apmwebdev added this to the Alpha release milestone Feb 5, 2024
@apmwebdev apmwebdev self-assigned this Feb 5, 2024
@apmwebdev
Copy link
Owner Author

Upon further analysis, converting HSL color to OKLCH is a full refactor, not a simple cleanup task. It has been spun out into its own issue in Change HSL color to OKLCH.

@apmwebdev apmwebdev mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apmwebdev apmwebdev

Labels
cleanup Too small to be a true "refactor," but same idea ui UI-specific issues, often CSS related
Projects
None yet
Milestone
Alpha release
Development

Successfully merging a pull request may close this issue.

Clean up CSS apmwebdev/spelling-bee
1 participant
@apmwebdev