Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vh might not be the right minimum height for mobile #111

Closed
apmwebdev opened this issue Feb 1, 2024 · 1 comment
Closed

vh might not be the right minimum height for mobile #111

apmwebdev opened this issue Feb 1, 2024 · 1 comment
Assignees
Labels
cleanup Too small to be a true "refactor," but same idea responsiveness Typically an issue with mobile/tablet layouts ui UI-specific issues, often CSS related
Milestone

Comments

@apmwebdev
Copy link
Owner

Making the minimum height of the app equal to the viewport height (vh) works well for desktop, but it seems slightly buggy for mobile. On Android, vh doesn't include the browser toolbar, since this hides itself when you scroll down. Therefore, when the browser toolbar is visible, the app is always taller than what is visible and has a vertical scroll bar, even if there's nothing relevant below the current view. The app renders as the height of the viewport and then is pushed down by the toolbar. I'm not sure if there's a way to do this, but it would be great if the min height could be the viewport height after the toolbar is rendered so that there isn't a vertical scroll bar if one is not needed.

@apmwebdev apmwebdev added cleanup Too small to be a true "refactor," but same idea ui UI-specific issues, often CSS related responsiveness Typically an issue with mobile/tablet layouts labels Feb 1, 2024
@apmwebdev apmwebdev added this to the Alpha release milestone Feb 1, 2024
@apmwebdev apmwebdev self-assigned this Feb 1, 2024
@apmwebdev
Copy link
Owner Author

Fixed in #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Too small to be a true "refactor," but same idea responsiveness Typically an issue with mobile/tablet layouts ui UI-specific issues, often CSS related
Projects
None yet
Development

No branches or pull requests

1 participant