Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The feedback is empty if the student shuts down the process with os._exit(0) #21

Open
markkuriekkinen opened this issue Mar 22, 2021 · 2 comments
Assignees

Comments

@markkuriekkinen
Copy link
Contributor

If the student's submission calls os._exit(0), the final feedback in A+ is completely empty. I assume that the python-grader-utils process shuts down and is not able to produce any output in the end.

Is the remote grader prototype able to fix this problem? If the grader main process and the submission process are separated, then the student can not shut down the main process.
https://github.com/apluslms/python-grader-utils/tree/remotegrader

@ihalaij1
Copy link
Contributor

ihalaij1 commented Apr 29, 2021

I got the remotegrader working with our recent updates to graderutils.
When using the remotegrader, os._exit(0) results in an EOFError when the rpyc connection is lost, but it does not shut down the main process.

os._exit() could probably be overridden in the student process so that it raises an exception stating that the command should not be used. Is this too hacky?

I think overriding could also work in the current non-rpyc graderutils.

@markkuriekkinen
Copy link
Contributor Author

I don't think this is urgent. We can now leave this waiting for the remote grader. We will then get a better overview of this whole thing.

If you are already finished with the remote grader, then I can take a look at that in May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants