Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry server: plan for addressing message-size limits. #1110

Open
timburks opened this issue Mar 20, 2023 · 1 comment
Open

Registry server: plan for addressing message-size limits. #1110

timburks opened this issue Mar 20, 2023 · 1 comment
Labels
question Further information is requested

Comments

@timburks
Copy link
Contributor

timburks commented Mar 20, 2023

gRPC has a default message size limit of 4MB. This is easily raised, so for self-hosted instances, that is probably the easiest way to support specs and artifacts that are larger than 4MB. But when other constraints limits prevent this, we're currently unable to load specs that are larger than a certain size (when compressed).

Compression helps significantly - the OpenAPI spec for Kubernetes 1.26.3 is 4620955 bytes and gzips to 285726 bytes, approximately 1/16th its uncompressed size. Because of this, we support and recommend uploading and downloading specs with gzip encoding.

Is that enough? What is a reasonable upper limit on compressed spec size?

What other upload/download options might we support?

@timburks timburks added the question Further information is requested label Mar 20, 2023
@timburks
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Discussion
Development

No branches or pull requests

1 participant