Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaClient][OAP] Improve Index Performance By Setting "no_sort" #12507

Open
2 of 3 tasks
hanahmily opened this issue Aug 4, 2024 · 3 comments
Open
2 of 3 tasks

[JavaClient][OAP] Improve Index Performance By Setting "no_sort" #12507

hanahmily opened this issue Aug 4, 2024 · 3 comments
Assignees
Labels
backend OAP backend related. enhancement Enhancement on performance or codes feature New feature
Milestone

Comments

@hanahmily
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

BanyanDB IndexRule supports the option to set no_sort to exclude sorted tables from the underlying index files. This field should be set to 'true' if the data does not need to be sorted based on a specific index.

For the Java client, sync the proto file to include support for this field.
For OAP, set this field to true for indexes that do not require sorting support.

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@hanahmily hanahmily added backend OAP backend related. feature New feature enhancement Enhancement on performance or codes labels Aug 4, 2024
@hanahmily hanahmily added this to the 10.1.0 milestone Aug 4, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Aug 5, 2024

I am not sure how to use this in OAP.
AFAIK, there isn't proper setting in OAP model to describe this.

@wu-sheng
Copy link
Member

wu-sheng commented Nov 3, 2024

@BanyanDB.NoSort could be considered.

Possible use cases should be similar with @ElasticSearch.DisableDocValues annotation, introduced in #12741

  1. Value column of metrics. This is not necessary in BanyanDB, as value column is different.
  2. Conditions of logs and traces(skywalking and zipkin) exclude latency and timestamp, which are used in sorting.
  3. All searchable field in metadata(*_traffic)

@hanahmily Please check both sides. I think separating two storage with making this concept more clear.

@wu-sheng wu-sheng assigned mrproliu and unassigned wankai123 Nov 4, 2024
@wu-sheng
Copy link
Member

wu-sheng commented Nov 4, 2024

@mrproliu As you have more time, please take a look at this after #12685
We should consider @BanyanDB.Sortable annotation because it seems all tag fields of BanyanDB. Only the tag is being used for query(e.g. latency in segment), we should add this annotation to activate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. enhancement Enhancement on performance or codes feature New feature
Projects
None yet
Development

No branches or pull requests

4 participants