From 801bbc8e970b05d5ff195ab4ed93ec0997481dc1 Mon Sep 17 00:00:00 2001 From: Ling Hengqian Date: Tue, 20 Sep 2022 09:53:47 +0800 Subject: [PATCH] Update `CODE_OF_CONDUCT.md` and `code.en.md` about hamcrest (#21046) --- CODE_OF_CONDUCT.md | 2 +- docs/community/content/involved/conduct/code.cn.md | 2 +- docs/community/content/involved/conduct/code.en.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index 382b846c51814..6b0d1de6764e2 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -61,7 +61,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND - Without particular reasons, test cases should be fully covered. - Every test case need precised assertion. - Environment preparation codes should be separate from test codes. - - Only those that relate to junit `Assert`, hamcrest `CoreMatchers` and `Mockito` can use static import. + - Only those that relate to `Mockito`, junit `Assert`, hamcrest `CoreMatchers` and `MatcherAssert` can use static import. - For single parameter asserts, `assertTrue`, `assertFalse`, `assertNull` and `assertNotNull` should be used. - For multiple parameter asserts, `assertThat` should be used. - For accurate asserts, try not to use `not`, `containsString` to make assertions. diff --git a/docs/community/content/involved/conduct/code.cn.md b/docs/community/content/involved/conduct/code.cn.md index 7c5c4fb54c2eb..2376fa1f54611 100644 --- a/docs/community/content/involved/conduct/code.cn.md +++ b/docs/community/content/involved/conduct/code.cn.md @@ -74,7 +74,7 @@ chapter = true - 除去简单的 `getter /setter` 方法，以及声明 SPI 的静态代码，如：`getType / getOrder`，单元测试需全覆盖。 - 每个测试用例需精确断言。 - 准备环境的代码和测试代码分离。 - - 只有 junit `Assert`，hamcrest `CoreMatchers`，Mockito 相关可以使用 static import。 + - 只有 Mockito，junit `Assert`，hamcrest `CoreMatchers` 和 `MatcherAssert` 相关可以使用 static import。 - 单数据断言，应使用 `assertTrue`，`assertFalse`，`assertNull` 和 `assertNotNull`。 - 多数据断言，应使用 `assertThat`。 - 精确断言，尽量不使用 `not`，`containsString` 断言。 diff --git a/docs/community/content/involved/conduct/code.en.md b/docs/community/content/involved/conduct/code.en.md index c22ebe77884a8..7c72389b071e8 100644 --- a/docs/community/content/involved/conduct/code.en.md +++ b/docs/community/content/involved/conduct/code.en.md @@ -72,7 +72,7 @@ The following code of conduct is based on full compliance with [ASF CODE OF COND - Test cases should be fully covered expect simply `getter /setter` methods, and declared static codes of SPI, such as: `getType / getOrder`. - Every test case need precised assertion. - Environment preparation codes should be separate from test codes. - - Only those that relate to junit `Assert`, hamcrest `CoreMatchers` and `Mockito` can use static import. + - Only those that relate to `Mockito`, junit `Assert`, hamcrest `CoreMatchers` and `MatcherAssert` can use static import. - For single parameter asserts, `assertTrue`, `assertFalse`, `assertNull` and `assertNotNull` should be used. - For multiple parameter asserts, `assertThat` should be used. - For accurate asserts, try not to use `not`, `containsString` to make assertions.