Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow override the Schema Creator by a consumer #1191

Open
adrianiacobghiula opened this issue Mar 1, 2024 · 2 comments
Open

allow override the Schema Creator by a consumer #1191

adrianiacobghiula opened this issue Mar 1, 2024 · 2 comments

Comments

@adrianiacobghiula
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A consumer should be allowed to select / choose / override the default Schema. For example select to use https://github.com/hamba/avro and not github.com/linkedin/goavro/v2

Describe the solution you'd like
Allow the consumer in Options to set a different function as SchemaCreator

@RobertIndie
Copy link
Member

Can you highlight the benefits of using https://github.com/hamba/avro? Given that https://github.com/linkedin/goavro has yet to see updates in 2 years, it might be worthwhile considering replacing it with https://github.com/hamba/avro if we have compelling reasons.

@adrianiacobghiula
Copy link
Contributor Author

@RobertIndie thanks for looking at the PR
I choose to use hamba because of avro to golang struct generation -> see avrogen.
Easier handling of "nullable" union. by having a field as pointer.
benchmark shows to be faster than linkedin.
There is a minus that hopefully with later versions can be covered: recursive structs not not covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants