[spark] Implement distributed orphan file clean for spark #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ulysses-you reopen this pr plz, we can review it continue. |
|
+1，nice. |
xuzifu666
approved these changes
Sep 19, 2024
JingsongLi
reviewed
Sep 19, 2024
| collectWithoutDataFile(branch, snapshot, usedFileConsumer, manifestConsumer) | ||
| usedFileBuffer | ||
| } | ||
| .toDS() |
There was a problem hiding this comment.
Should we cache this DS to avoid computing twice?
| } | ||
| val manifestConsumer = new Consumer[ManifestFileMeta] { | ||
| override def accept(t: ManifestFileMeta): Unit = { | ||
| isManifestMetaFile = true |
There was a problem hiding this comment.
This looks very weird, and this protocol may be break.
Can you just refactor collectWithoutDataFile to pass only one Consumer<Pair<String, Boolean>>, file and isManifestFile.
There was a problem hiding this comment.
agree, changed to use Consumer<Pair<String, Boolean>>
|
Please add close #4184 in comment too. |
xuzifu666
reviewed
Sep 19, 2024
| @@ -104,7 +104,7 @@ class RemoveOrphanFilesProcedureTest extends PaimonSparkTestBase { | |||
| checkAnswer( | |||
| spark.sql( | |||
| s"CALL sys.remove_orphan_files(table => 'T', older_than => '$older_than', dry_run => true)"), | |||
| Row(orphanFile1.toUri.getPath) :: Row(orphanFile2.toUri.getPath) :: Nil | |||
| Row(2) :: Nil | |||
There was a problem hiding this comment.
Maybe need add a test line for each case at end with 'checkAnswer(spark.sql(s"CALL sys.remove_orphan_files(table => 'T')"), Row(0) :: Nil)' to comfire no orphan files.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pr supports distributed orphan file clean for spark using
Datasetinterface.Tests
add test
API and Format
no
Documentation