[core] Manifest table query throw exception with range of snapshot when snapshot id not exist #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exist to reminder with range of snapshot
LinMingQiang
reviewed
Sep 8, 2024
| throw new RuntimeException( | ||
| String.format( | ||
| "scan.snapshot-id is not exist, you can set it in range from %s to %s", | ||
| earliestSnapshotId, latestSnapshotId)); |
There was a problem hiding this comment.
better : Specified scan.snapshot-id [%s] is not exist, .....
There was a problem hiding this comment.
Thanks，your advice is nice. @LinMingQiang
LinMingQiang
reviewed
Sep 8, 2024
| String.format( | ||
| "Specified scan.snapshot-id %s is not exist, you can set it in range from %s to %s", | ||
| snapshotId, earliestSnapshotId, latestSnapshotId)); | ||
| } |
There was a problem hiding this comment.
SnapshotNotExistException
|
+1 |
wxplovecc
pushed a commit
to tongcheng-elong/incubator-paimon
that referenced
this pull request
Sep 10, 2024
…en snapshot id not exist (apache#4145) (cherry picked from commit e083825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Purpose
Currently user can only query table manifest info of snapshot from scan.snapshot-id, due to snapshot manager of table, some early snapshot would clean. So maybe need offer user about snapshot range when user query a snapshot id which not exist.
Linked issue: close #xxx
Tests
API and Format
Documentation