Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Introduce SplitGroup for SplitGenerator #3059

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Mar 20, 2024

Purpose

  • make SplitGenerator return files + rawConvertible
  • optimizer split generate

Tests

API and Format

Documentation

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zouxxyy , can you add more tests for your modification?

@Zouxxyy
Copy link
Contributor Author

Zouxxyy commented Mar 25, 2024

Hi @Zouxxyy , can you add more tests for your modification?

Added~

@JingsongLi
Copy link
Contributor

any idea about above comment: oneLevel and not zero level.?

@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 9839efa into apache:master Mar 26, 2024
8 of 9 checks passed
zhuangchong pushed a commit to zhuangchong/flink-table-store that referenced this pull request Mar 26, 2024
zhu3pang pushed a commit to zhu3pang/incubator-paimon that referenced this pull request Mar 29, 2024
@Zouxxyy Zouxxyy deleted the dev/split-opt branch March 31, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants