Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the length of lock_id #3013

Closed
wants to merge 1 commit into from

Conversation

gaoyan1998
Copy link

@gaoyan1998 gaoyan1998 commented Mar 14, 2024

Linked issue: close #3012

@sunxiaojian
Copy link
Contributor

sunxiaojian commented Mar 15, 2024

@gaoyan1998 The length of the 'lock_id' field in distributed lock tables cannot be reduced on its own. The 'lock_id' is a concatenation of 'catalog_key', 'database_name', and 'table_name'.

@gaoyan1998
Copy link
Author

@gaoyan1998 The length of the 'lock_id' field in distributed lock tables cannot be reduced on its own. The 'lock_id' is a concatenation of 'catalog_key', 'database_name', and 'table_name'.

@sunxiaojian Yes, but I think that even these fields together should not need 1000 so long,i cant understand, if there are concerns can also be set to 500 or 700, I think it is also enough, 1000 will lead to mysql table create problems, its exceeded the maximum index limit.

Of course this can be solved by modifying the mysql parameters, but this is a heavier operation, especially in a production environment.

Just a small suggestion when using it, there may be other things I'm not thinking about, and if it really doesn't work I can close this pr

@JingsongLi
Copy link
Contributor

I think it is better to provide a option for this length.

@gaoyan1998
Copy link
Author

I think it is better to provide a option for this length.

What kind of option?

@sunxiaojian
Copy link
Contributor

I think it is better to provide a option for this length.

What kind of option?

refer: #3069

@JingsongLi JingsongLi closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Why JDBC metastore LOCK_ID so big?
3 participants