Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track LICENSE and NOTICE issues for incubator-openwhisk-client-go #98

Closed
mrutkows opened this issue Apr 9, 2018 · 4 comments
Closed

Comments

@mrutkows
Copy link
Contributor Author

mrutkows commented Apr 9, 2018

As per discussion in wskdeploy related issue: #94

@daisy-ycguo @houshengbo we have need to document that we have decided not to include the generated "i18n_resources.go" file and are unable to add a header comment to its source input file (i.e., en_US.all.json or other similar language/country coded JSON files).

IMO, we should include this decision/logic in this repo's LICENSE file.

@daisy-ycguo
Copy link
Member

An issue is created to track the header issue: apache/openwhisk-client-go#68

@daisy-ycguo
Copy link
Member

A PR apache/openwhisk-client-go#79 is created. After this PR is merged, all files are with headers except the exclusions defined in Markdown file.

@mrutkows mrutkows changed the title Document LICENSE file Exclusions for incubator-openwhisk-client-go Track LICENSE and NOTICE issues for incubator-openwhisk-client-go May 17, 2018
@houshengbo
Copy link

We can close this issue, since all the PRs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants