Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability of CLI via Homebrew #153

Closed
csantanapr opened this issue Nov 22, 2017 · 11 comments
Closed

Availability of CLI via Homebrew #153

csantanapr opened this issue Nov 22, 2017 · 11 comments

Comments

@csantanapr
Copy link
Member

@andrepoleza commented on Mon Aug 15 2016

Hello!

I've read the documentation and became (more) interested in OpenWhisk, but I've notice that the CLI isn't published on Homebrew... Is there a reason to not be there?


@csantanapr commented on Mon Aug 15 2016

Hi @andrepoleza for your interest in OpenWhisk.
We have no specific reason why the CLI is not available thru Homebrew.
I think homebrew is a good way of installing dev tools, and it could be a good vehicle to distribute the CLI.

Like anything it would take effort to get it done and also maintain it current (automation CI/CD).

We also need to do some bit of research on how to handle, nightly publish vs. a stable build with the current situation that the CLI doesn't have a semantic version only a hash or build id (i.e. date stamp)

I think after we figured out this we could also potentially offer the CLI thru other package manager (i.e. npm install -g whisk-cli)

I will keep the issue open to keep this a a enhancement request.


@andrepoleza commented on Tue Aug 16 2016

Good to know! I've never thought about the semantic version and its impact on availability on Homebrew. I just think that distributing the CLI through a broader package manager would benefit OpenWhisk in several ways, because although npm and pip are stable/popular not every (potential) developer uses them.

Anyway, I'll be happy when OpenWhisk reaches Homebrew. 😃


@jthomas commented on Fri Oct 14 2016

I did an experiment with exposing the CLI through Homebrew recently.
https://github.com/jthomas/homebrew-tools/blob/master/wsk.rb

It worked perfectly although this file now fails the checksum test because the Go CLI has been updated.

If we could work out how to trigger building this file when the Go CLI changes, you can just drop that repo in the OpenWhisk org and it'll work.


@dubeejw commented on Tue Oct 18 2016

@jthomas, we could create the needed file during the CLI build, and add the required checksum during that process as well.


@jthomas commented on Tue Oct 18 2016

That would be awesome.

@mgernand
Copy link

Any news on this one?

@csantanapr
Copy link
Member Author

I think if generate checksum files and include as part of the release attachments we could integrate using homebrew tap

@Juice10
Copy link
Contributor

Juice10 commented May 2, 2018

I would love to see this one! A lot of our documentation infers you magically have wsk set in your shell's $PATH. It's super confusing for users new to the project.

I personally actually went down the rabbit hole of compiling my own wsk cli because I wasn't sure what the appropriate steps where to install it.

Distributing the cli via brew, apt-get and the windows equivalent will help tremendously as we can just list our cli install step to be

On Mac, install homebrew if you haven't already. Then run $ brew install wsk

and have the whole thing be basically fool proof.

@dubee
Copy link
Member

dubee commented May 2, 2018

@Juice10, after doing a deployment of OpenWhisk with Ansible the CLI should be available in the bin directory of cloned OpenWhisk repo.

@mdeuser, @drcariel, FYI on the above comment.

@drcariel
Copy link
Contributor

drcariel commented May 2, 2018

related to apache/openwhisk#1880

@Juice10
Copy link
Contributor

Juice10 commented Aug 17, 2018

I submitted wsk & wskdeploy to Homebrew: Homebrew/homebrew-core#31231

@csantanapr
Copy link
Member Author

We need a new Apache version voted and released like “0.10.0-incubating” first

@alexkli
Copy link

alexkli commented Feb 2, 2019

Both wsk and wskdeploy are now available on homebrew. So I think this issue can be closed.

However, for wsk only the 6 month old 0.0.9-incubating version is available, while the latest release isn't - and it includes some important new features like concurrency.

As a quick fix, I added a custom wsk-latest formula in my custom homebrew tap:

# only if you have wsk installed through homebrew
brew unlink wsk

brew tap alexkli/tap
brew install alexkli/tap/wsk-latest

wsk property get --cliversion
> whisk CLI version	2019-01-26T20:01:45.357+0000

But this is a bit annoying because of the brew unlink and switching back and forth between the two. With a separate formula, homebrew does not know that this is the same software, just a pre-release version.

IIUC, latest is not considered a stable release (e.g. it does not have a version number) and would be opt-in for early adopters. In Homebrew this can be done properly by adding a devel version in the formula, that can be installed using brew install --devel wsk.

Would be cool if someone wants to tackle that - I could maybe in 2 weeks. And should that be a separate issue?

@csantanapr
Copy link
Member Author

I was not aware of the —devel flag it would awesome if someone can implement this +1

@rabbah
Copy link
Member

rabbah commented Feb 14, 2019

Created #410.

@rabbah rabbah closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants