refactor(layers/prometheus-client): provide builder APIs #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Xuanwo maybe you can also take a look at this PR? |
koushiro
commented
Aug 30, 2024
core/src/layers/prometheus_client.rs
Outdated
|
|
||
| fn register(&self, registry: &mut Registry) { | ||
| registry.register_with_unit( | ||
| "opendal_operation_duration", |
There was a problem hiding this comment.
we can't use observe::METRIC_OPERATION_DURATION_SECONDS.name() here, prometheus-client will generate opendal_operation_duration_seconds_seconds metric
There was a problem hiding this comment.
maybe we should use register instead of register_with_unit here, then we could use observe::METRIC_OPERATION_DURATION_SECONDS.name()
koushiro
commented
Aug 30, 2024
koushiro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related issue: #5069 (comment)
Related PR: #5072
Rationale for this change
Provide similar APIs for
PrometheusLayerandPrometheusClientLayerWhat changes are included in this PR?
PrometheusLayerPrometheusClientLayer::builderPrometheusClientLayerBuilderOperationErrorsTotalLabelsAre there any user-facing changes?
API breaking change