Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/azblob): support multi write for azblob #4181

Merged
merged 25 commits into from
Feb 18, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Feb 14, 2024

This pr tend to implement unsized write for azblob based on newly added BlockWriter.

@Xuanwo Xuanwo changed the title feat(services/azblob): support unsized write for azblob feat(services/azblob): support multi write for azblob Feb 14, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Feb 14, 2024

Please fix the CI.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Feb 17, 2024

Seems that the failed CI is not related to this PR, once seafile, and this time webdav, may be network issue?

@Xuanwo
Copy link
Member

Xuanwo commented Feb 17, 2024

Seems that the failed CI is not related to this PR, once seafile, and this time webdav, may be network issue?

Yep. I think they are unrelated too. I will review this PR tomorrow.

core/Cargo.toml Outdated Show resolved Hide resolved
core/Cargo.toml Outdated Show resolved Hide resolved
core/src/services/azblob/core.rs Outdated Show resolved Hide resolved
core/src/services/azblob/core.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit e668413 into apache:main Feb 18, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants