Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new feature: Implement append object for S3 #5351

Open
1 task
Xuanwo opened this issue Nov 22, 2024 · 3 comments · May be fixed by #5428
Open
1 task

new feature: Implement append object for S3 #5351

Xuanwo opened this issue Nov 22, 2024 · 3 comments · May be fixed by #5428
Labels
enhancement New feature or request help wanted Extra attention is needed services/s3

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2024 •
edited
Loading

Feature Description

AWS S3 supports append object for directory-buckets now.

https://docs.aws.amazon.com/AmazonS3/latest/userguide/directory-buckets-objects-append.html

Problem and Solution

OpenDAL already has the append API, we just need to support append mode for s3.

Users can append to object via:

let writer = op.writer_with(path).append(true).await?;
writer.write(bs).await?;
writer.close().await?;

Additional Context

No response

Are you willing to contribute to the development of this feature?

  • Yes, I am willing to contribute to the development of this feature.
@Xuanwo Xuanwo added enhancement New feature or request help wanted Extra attention is needed services/s3 labels Nov 22, 2024
@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 22, 2024

NOTE: AWS S3 can append on an existing object created by PutObject or multipart uploads. That's different from other services.

image

@Frank-III
Copy link
Contributor

NOTE: AWS S3 can append on an existing object created by PutObject or multipart uploads. That's different from other services.

image

I want to work on this! I checked how others implement append but what would this make the implementation different? Should we just modify the put method, and make the writer a TwoWays?

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 18, 2024

I want to work on this! I checked how others implement append but what would this make the implementation different? Should we just modify the put method, and make the writer a TwoWays?

Hi, we can take oss as a reference:

opendal/core/src/services/oss/writer.rs

Line 165 in a9d0ec6

impl oio::AppendWrite for OssWriter {

@Frank-III Frank-III linked a pull request Dec 18, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed services/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(services/s3): add append support Frank-III/opendal
2 participants
@Xuanwo @Frank-III